Repository navigation
feat(anomaly detection):preview chart proxy api endpoint - #77813
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77813 +/- ##
===========================================
+ Coverage 61.67% 75.93% +14.25%
===========================================
Files 6970 6982 +12
Lines 309249 309845 +596
Branches 50629 50694 +65
===========================================
+ Hits 190730 235278 +44548
+ Misses 112656 67834 -44822
- Partials 5863 6733 +870 |
mifu67
marked this pull request as ready for review
September 20, 2024 16:58
iamrajjoshi
reviewed
Sep 20, 2024
ceorourke
reviewed
Sep 20, 2024
| ) | ||
| def _format_historical_data(self, data) -> list[TimeSeriesPoint] | None: | ||
| """ | ||
| Format EventsStatsData into the format that the Seer API expects. |
Contributor
There was a problem hiding this comment.
Mostly as a note to myself, but after my other pr lands we should be able to consolidate these functions and only have one. Mine serializes the data to get it into the format you're expecting here, but I can just do that before calling the function.
ceorourke
reviewed
Sep 20, 2024
natemoo-re
approved these changes
Sep 20, 2024
natemoo-re
left a comment
natemoo-re
left a comment
Member
There was a problem hiding this comment.
Looks good! Consider my comments non-blocking, but a few small things to think through.
ceorourke
reviewed
Sep 20, 2024
ceorourke
approved these changes
Sep 20, 2024
ceorourke
left a comment
ceorourke
left a comment
Contributor
There was a problem hiding this comment.
Left some non-blocking comments but otherwise looks good!
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build out the preview chart proxy endpoint. Calls a placeholder function.